fix: correct residue_string expected type#178
Open
RubenChM wants to merge 1 commit intoDiscngine:masterfrom
Open
fix: correct residue_string expected type#178RubenChM wants to merge 1 commit intoDiscngine:masterfrom
RubenChM wants to merge 1 commit intoDiscngine:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the declaration of
residue_stringfrom an array of pointers (char *[]) to a standard character buffer (char []) and remove the address-of operator (&) when passing the buffer tostrcpy, resolving the compiler (GCC 15) error:The old implementation was working fine since we are pointing to the same spot in memory, but it was taking 8 times more space for the buffer.
This closes #164 and allows the
conda-forgeto rebuild without adding constrains to the compiler version.